[webkit-reviews] review granted: [Bug 49628] Set the original URL for downloads : [Attachment 74047] Patch

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 49628: Set the original URL for downloads
https://bugs.webkit.org/show_bug.cgi?id=49628

Attachment 74047: Patch
https://bugs.webkit.org/attachment.cgi?id=74047&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74047&action=review

> WebKit2/WebProcess/Downloads/mac/DownloadMac.mm:68
> +}

It's non-obvious why we can get the originating URL from the back/forward list.
The old code in WebFrameLoaderClient.mm included a few comments and a FIXME
that make this a little clearer. I think it's worthwhile to reproduce those
comments and FIXME here. (I see one of them is now in
setOriginalURLForDownload, but the others aren't.)

It might also help to name this function originatingURLFromBackForwardList,
since it's only used when there's no referrer.