[webkit-reviews] review granted: [Bug 49563] [chromium] Fix negative letter spacing in complex text on linux : [Attachment 74048] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 49563: [chromium] Fix negative letter spacing in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49563

Attachment 74048: Patch
https://bugs.webkit.org/attachment.cgi?id=74048&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74048&action=review

One option for chromium win/mac is to mark the test as expected to fail, which
gives you a chance to rebaseline it without turning the tree red.  gtk, qt, and
win, you'll just have to break the tree and grab the results from the
waterfall.

> WebCore/platform/graphics/chromium/FontLinux.cpp:54
> +using namespace std;

Can we do without this?

> WebCore/platform/graphics/chromium/FontLinux.cpp:561
> +    m_pixelWidth = max(position, 0.0);

std::max seems safer to avoid ambiguity.