[webkit-reviews] review granted: [Bug 49613] [V8] ASSERT(WTF::isMainThread()) fails in V8Binding::int32ToWebCoreString in workers : [Attachment 74028] Proposing patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 16 13:10:31 PST 2010
Nate Chapin <japhet at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 49613: [V8] ASSERT(WTF::isMainThread()) fails in
V8Binding::int32ToWebCoreString in workers
https://bugs.webkit.org/show_bug.cgi?id=49613
Attachment 74028: Proposing patch
https://bugs.webkit.org/attachment.cgi?id=74028&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74028&action=review
Other than the style nits, this looks ok. However, I'd appreciate it if you
waited for antonm to agree before committing :)
> WebCore/bindings/v8/V8Binding.cpp:390
> } else
> - webCoreString = String::number(value);
> + webCoreString = String::number(value);
Indent 4.
> WebCore/bindings/v8/V8Binding.cpp:399
> + if (WTF::isMainThread())
> + return int32ToWebCoreStringFast(value);
Indent 4.
More information about the webkit-reviews
mailing list