[webkit-reviews] review granted: [Bug 49187] [NRWT] Make http locking similar to perl implementation : [Attachment 73901] proposed_patch_v3

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 49187: [NRWT] Make http locking similar to perl implementation
https://bugs.webkit.org/show_bug.cgi?id=49187

Attachment 73901: proposed_patch_v3
https://bugs.webkit.org/attachment.cgi?id=73901&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73901&action=review

> WebKitTools/Scripts/webkitpy/common/system/file_lock.py:36
> +    def __init__(self, lock_file_path, max_wait_time=20):

Nit: I prefer to have the units included in time variables.  E.g.,
max_wait_time_sec

> WebKitTools/Scripts/webkitpy/common/system/file_lock.py:65
> +	       except IOError:
> +		   if time.time() - start_time > self._max_wait_time:

Maybe we should log the error here for debugging purposes?

> WebKitTools/Scripts/webkitpy/common/system/file_lock.py:78
> +	   except (IOError, OSError):
> +	       pass

Should we log the error here too?