[webkit-reviews] review requested: [Bug 41441] createWindow method should only do window-creating without URL navigator : [Attachment 73983] Patch V3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 16 05:01:53 PST 2010


Xianzhu Wang <phnixwxz at gmail.com> has asked  for review:
Bug 41441: createWindow method should only do window-creating without URL
navigator
https://bugs.webkit.org/show_bug.cgi?id=41441

Attachment 73983: Patch V3
https://bugs.webkit.org/attachment.cgi?id=73983&action=review

------- Additional Comments from Xianzhu Wang <phnixwxz at gmail.com>
This patch changes all createWindow implementations to remove URL navigations
in them.
Now full request containing the URL is passed to createWindow for it only to
check if the request can be fulfilled.

WebCore::createWindow is still in FrameLoader.cpp to keep this change small. I
prefer doing it later in a separate change.


More information about the webkit-reviews mailing list