[webkit-reviews] review requested: [Bug 48986] [GTK] Some key-press events can't be handled by WebView : [Attachment 73981] Patch to fix the problem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 16 04:19:38 PST 2010


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 48986: [GTK] Some key-press events can't be handled by WebView
https://bugs.webkit.org/show_bug.cgi?id=48986

Attachment 73981: Patch to fix the problem
https://bugs.webkit.org/attachment.cgi?id=73981&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
The problem is that "popup-menu" and "show-help" signals are handled by
GtkTextView, as they are added to the key bindings set of every widget in
gtk_widget_class_init(). For all other bindings handled by GtkTextView we are
stopping the signal emission in their callbacks, so we only need to do the same
for "popup-menu" and "show-help" signals.


More information about the webkit-reviews mailing list