[webkit-reviews] review denied: [Bug 45631] Scroll event should be fired asynchronously : [Attachment 73927] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 45631: Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631

Attachment 73927: Patch
https://bugs.webkit.org/attachment.cgi?id=73927&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73927&action=review

I don’t think there’s a need to have a separate queue for each node. A single
queue per document should suffice.

> WebCore/dom/NodeRareData.h:120
> +	       m_eventQueue.set(new EventQueue(target));

This creates a circular reference and hence leaks any node that ever has an
event queue. The node owns the rare data, the rare data owns the event queue,
and the event queue refs the node.