[webkit-reviews] review granted: [Bug 42370] Scaled Resized images are blurred when sent to Skia : [Attachment 73740] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 42370: Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370

Attachment 73740: Patch
https://bugs.webkit.org/attachment.cgi?id=73740&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73740&action=review

R=me, but test could be a bit better - please see comments.

> LayoutTests/svg/custom/image-rescale-scroll.html:21
> +    setTimeout("var occluder = document.getElementById('occluder');
occluder.style.top = 600;", 50);
> +    setTimeout("endTest()", 100); // Let repaint complete before ending
test.

Instead of doing this, you can use layoutTestController.display() to force an
immediate repaint.  This will make the test run a bit faster and be more
reliable.  LayoutTests/fast/repaint/resources.js has some basic helper
functions.  Take a look at
http://trac.webkit.org/browser/trunk/LayoutTests/fast/repaint/reflection-redraw
.html as one example.