[webkit-reviews] review denied: [Bug 47813] [HTML5] "form" attribute support for form control elements : [Attachment 73828] Patch V4

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 47813: [HTML5] "form" attribute support for form control elements
https://bugs.webkit.org/show_bug.cgi?id=47813

Attachment 73828: Patch V4
https://bugs.webkit.org/attachment.cgi?id=73828&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73828&action=review

> LayoutTests/fast/forms/form-attribute-expected.txt:7
> +FIXME: <label> and <object> don't support the form attribute for now.

nit: It's ok to add test cases for <label> and <object> now. -expected.txt
contains FAIL lines in that case.

> WebCore/dom/Document.cpp:4368
> +void Document::registerFormElementWithFormAttribute(Element* e)

The parameter name "e" is not good.  It should be "control", "formControl",
"element" or something.

> WebCore/dom/Document.cpp:4374
> +void Document::unregisterFormElementWithFormAttribute(Element* e)

ditto.

> WebCore/dom/Document.h:487
> +    void registerFormElementWithFormAttribute(Element* e);
> +    void unregisterFormElementWithFormAttribute(Element* e);

The argument name "e" doesn't add any useful information.  So we should remove
it.

> WebCore/html/HTMLFormElement.cpp:418
> +	   unsigned middle = (left + right) / 2;

Possible integer overflow.  Fix it.