[webkit-reviews] review granted: [Bug 49500] Buildfix for !ENABLE(INSPECTOR) : [Attachment 73833] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 13 23:37:15 PST 2010


Yury Semikhatsky <yurys at chromium.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 49500: Buildfix for !ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=49500

Attachment 73833: Patch
https://bugs.webkit.org/attachment.cgi?id=73833&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
Thanks for fixing this. The problem must have appeared after
http://trac.webkit.org/changeset/71515 where I reasoned that ENABLED(INSPECTOR)
guards can be removed from the ConsoleMessage.cpp because the latter is only
used by the inspector code itself.  I confined my check to compilation of
--minimal build which is usually enough to see if there are any issues related
to ENABLED(INSPECTOR) macro.


More information about the webkit-reviews mailing list