[webkit-reviews] review granted: [Bug 49499] broken-ideographic-font.html fails in release builds : [Attachment 73832] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 49499: broken-ideographic-font.html fails in release builds
https://bugs.webkit.org/show_bug.cgi?id=49499

Attachment 73832: Patch
https://bugs.webkit.org/attachment.cgi?id=73832&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=73832&action=review

> WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:44
> -    unsigned key = typesettingFeatures + 1;
> +    unsigned key = 1 + ((typesettingFeatures | (orientation() == Vertical ?
4 : 0)) << 1);

I don’t like this part of the change. orientation() is always the same for a
SimpleFontData instance, so there’s never a need to include it in the key.