[webkit-reviews] review denied: [Bug 49341] REGRESSION: Select combo-box not displayed : [Attachment 73822] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 49341: REGRESSION: Select combo-box not displayed
https://bugs.webkit.org/show_bug.cgi?id=49341

Attachment 73822: Patch
https://bugs.webkit.org/attachment.cgi?id=73822&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch does not fix the <keygen> tests.  Those tests likely pass on Qt
without this patch.  Also, this patch changes webkit01.dat, which shouldn't be
changed.  It's content reflect the state of the HTML5 spec.  If you want to
change that file, you'll first need to change the spec and then change the dat
file to match the spec.

As far as I can tell, this patch causes us to violate the HTML5 spec.  If
there's a good reason to change the parser in this way, we should present our
case to the HTML working group and get the spec changed.  That ensures that
everyone implementing the HTML5 parsing algorithm gets the same result.