[webkit-reviews] review denied: [Bug 40887] requiredFeatures does not adapt to SVGStringList changes : [Attachment 73821] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 40887: requiredFeatures does not adapt to SVGStringList changes
https://bugs.webkit.org/show_bug.cgi?id=40887

Attachment 73821: Patch
https://bugs.webkit.org/attachment.cgi?id=73821&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73821&action=review

>
LayoutTests/svg/dynamic-updates/script-tests/SVGUseElement-dom-requiredFeatures
.js:29
> +    debug("Check that adding something valid to requiredFeatures keeps
rendering the element");
> +    useElement.setAttribute("requiredFeatures",
"http://www.w3.org/TR/SVG11/feature#Path");
> +    shouldBeEqualToString("document.defaultView.getComputedStyle(useElement,
null).display", "");

This looks wrong to me. Talked with Rob and we found out that #Path is not a
valid feature. He'll investigate.