[webkit-reviews] review denied: [Bug 49481] Implement WebKit Full Screen support : [Attachment 73793] WebCore-RenderFullScreen

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 12 23:16:49 PST 2010


Adam Barth <abarth at webkit.org> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 49481: Implement WebKit Full Screen support
https://bugs.webkit.org/show_bug.cgi?id=49481

Attachment 73793: WebCore-RenderFullScreen
https://bugs.webkit.org/attachment.cgi?id=73793&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73793&action=review

>> WebCore/rendering/RenderFullScreen.cpp:8
>> +/*
>> + *	RenderFullScreen.cpp
>> + *	WebCore
>> + *
>> + *	Created by Jer Noble on 10/25/10.
>> + *	Copyright 2010 Apple Computer. All rights reserved.
>> + *
>> + */
> 
> Briefly glanced at this patch and noticed that this comment is similar to the
default Xcode copyright comment. Instead, this file should have the same
copyright comment as in RenderFullScreen.h. Also, while the license in
RenderFullScreen.h is sufficient it differs in wording from the Apple license
used in Apple-contributed files, see
<http://trac.webkit.org/browser/trunk/WebKit/LICENSE>.

Good point.  We need a WebKit-compatible license block.


More information about the webkit-reviews mailing list