[webkit-reviews] review denied: [Bug 47196] Implement UNPACK_COLORSPACE_CONVERSION_WEBGL : [Attachment 73679] patch: hook up UNPACK_COLORSPACE_CONVERSION setting to texture uploading.

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 47196: Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

Attachment 73679: patch: hook up UNPACK_COLORSPACE_CONVERSION setting to
texture uploading.
https://bugs.webkit.org/attachment.cgi?id=73679&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73679&action=review

r- for naming inconsistency throughout the code. I think the argument should be
more properly named ignoreGammaAndColorProfile.

> WebCore/platform/graphics/qt/ImageDecoderQt.cpp:40
> +ImageDecoder* ImageDecoder::create(const SharedBuffer& data, bool
premultiplyAlpha, bool ignoreGamma)

Everywhere else throughout the code this is called "ignoreColorProfile". The
code should be consistent.

> WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
> +    return new ImageDecoderQt(premultiplyAlpha, ignoreGamma);

Here too.

> WebCore/platform/graphics/qt/ImageDecoderQt.cpp:50
> +ImageDecoderQt::ImageDecoderQt(bool premultiplyAlpha, bool ignoreGamma)
> +    : ImageDecoder(premultiplyAlpha, ignoreGamma)

Here too.

> WebCore/platform/graphics/qt/ImageDecoderQt.h:44
> +    ImageDecoderQt(bool premultiplyAlpha, bool ignoreGamma);

Here too.

> WebKit/chromium/ChangeLog:9
> +	   (WebKit::WebImageDecoder::init): Add ignoreColorSpace parameter.

ignoreColorSpace doesn't match the naming of the argument throughout the code.