[webkit-reviews] review denied: [Bug 49463] [V8] Code generation script error in generating the SVGStaticListPropertyTearOff : [Attachment 73783] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 12 16:38:10 PST 2010
Andreas Kling <kling at webkit.org> has denied webkittenghui at gmail.com's request
for review:
Bug 49463: [V8] Code generation script error in generating the
SVGStaticListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=49463
Attachment 73783: proposed patch
https://bugs.webkit.org/attachment.cgi?id=73783&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73783&action=review
> WebCore/ChangeLog:5
> + Need a short description and bug URL (OOPS!)
Oops indeed, this should be replaced by something like:
[V8] Code generation script error in generating the
SVGStaticListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=49463
> WebCore/ChangeLog:7
> + No new tests. (OOPS!)
If you're not adding any tests, this should be replaced by something like:
No new tests, this is already covered by X, Y and Z.
OR
No new tests, this is untestable for reason X.
Of course, if it's a compile fix, just remove this line. :-)
More information about the webkit-reviews
mailing list