[webkit-reviews] review granted: [Bug 49484] Some FrameLoader.h Cleanup : [Attachment 73791] [PATCH] Proposed Change

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 49484: Some FrameLoader.h Cleanup
https://bugs.webkit.org/show_bug.cgi?id=49484

Attachment 73791: [PATCH] Proposed Change
https://bugs.webkit.org/attachment.cgi?id=73791&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73791&action=review

> WebCore/ChangeLog:23
> +	   Removed function signatures without any implementation. The
functions
> +	   used to exist, and were nicely refactored into PageCache in r60688
and
> +	   the signatures were left behind.
> +
> +	   Removed function signature setLoadType. Added in r17238 back when
the
> +	   file was named WebFrameLoader, and the implementation was lost
during
> +	   the transition from its mm implementation.
> +
> +	   Removed function signature updateHistoryAfterClientRedirect.
Implementation
> +	   and call points were removed in r18541 but the signature was left
behind,
> +	   and jumped files!
> +
> +	   Removed unused debug variable m_didDispatchDidCommitLoad. It was
added
> +	   and used in Assertions in r28399. It was removed soon after, in
r28464
> +	   because they were, "firing like crazy. Not sure why yet." It was
> +	   never used again.

I'd probably put this in the bug, not ChangeLog. But it's nothing compared to
the fact that you actually investigated the history in such detail, that's
really nice.