[webkit-reviews] review denied: [Bug 49396] Make WebWidget actively notify client when compositing enables : [Attachment 73633] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nat Duca
<nduca at chromium.org>'s request for review:
Bug 49396: Make WebWidget actively notify client when compositing enables
https://bugs.webkit.org/show_bug.cgi?id=49396

Attachment 73633: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=73633&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73633&action=review

> WebKit/chromium/src/WebViewImpl.cpp:2383
> +	   m_layerRenderer->finish(); // finish all GL rendering before we hide
the window? TODO(nduca) fixthisshit

TODO(nduca) -> FIXME and leave a more descriptive comment for someone else who
may be reading this code.

> WebKit/chromium/src/WebViewImpl.cpp:2390
> +	   m_layerRenderer->resizeOnscreenContent(WebCore::IntSize(std::max(1,
m_size.width),

no need for the WebCore prefix.

> WebKit/chromium/public/WebWidgetClient.h:54
> +    virtual void didChangeAcceleratedCompositingActive(bool active) { }

nit: how about didActivateAcceleratedCompositing(bool)?