[webkit-reviews] review granted: [Bug 49443] cpp.py needs some tidying. : [Attachment 73741] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 12 10:07:48 PST 2010


Adam Barth <abarth at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 49443: cpp.py needs some tidying.
https://bugs.webkit.org/show_bug.cgi?id=49443

Attachment 73741: Patch
https://bugs.webkit.org/attachment.cgi?id=73741&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73741&action=review

Looks good, but there's a typo in you ChangeLog.  >:-)

> WebKitTools/ChangeLog:9
> +	     Fix parametere ordering for iteratively_replace_matches_with_char

parametere ?

> WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:1205
> -	   if not body_found:
> +	   else:

Woah


More information about the webkit-reviews mailing list