[webkit-reviews] review granted: [Bug 49426] KeyboardEvent::keyIdentifier() should return "const String&" : [Attachment 73701] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 12 04:43:19 PST 2010


Andreas Kling <kling at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 49426: KeyboardEvent::keyIdentifier() should return "const String&"
https://bugs.webkit.org/show_bug.cgi?id=49426

Attachment 73701: Patch
https://bugs.webkit.org/attachment.cgi?id=73701&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
You missed this one, please fix before landing.
WebKit/mac/WebCoreSupport/WebEditorClient.mm:646:    String key =
event->keyIdentifier();


More information about the webkit-reviews mailing list