[webkit-reviews] review granted: [Bug 49427] check-webkit-style function detection doesn't handle templates with spaces. : [Attachment 73702] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 11 23:07:43 PST 2010
Shinichiro Hamaji <hamaji at chromium.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 49427: check-webkit-style function detection doesn't handle templates with
spaces.
https://bugs.webkit.org/show_bug.cgi?id=49427
Attachment 73702: Patch
https://bugs.webkit.org/attachment.cgi?id=73702&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73702&action=review
> WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2452
> + ('my_namespace::my_other_namespace::MyVeryLongTypeName<Type1,
Type5>*\n'
As now we can handle something like MyVeryLongTypeName<Type1, Type5<Type6,
Type7> > , it's worth having such test case?
More information about the webkit-reviews
mailing list