[webkit-reviews] review denied: [Bug 23351] Add preference to not select when right-clicked : [Attachment 73666] New version, with layout test

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 23351: Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351

Attachment 73666: New version, with layout test
https://bugs.webkit.org/attachment.cgi?id=73666&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73666&action=review

> WebCore/editing/EditingBehavior.h:61
> +    // On Mac/Unix, when processing a contextual click, the object being
clicked upon should be selected.
> +    bool shouldSelectOnContextualMenuClick() const { return m_type ==
EditingMacBehavior || m_type == EditingUnixBehavior; }

Sorry Avi, maybe I misexplained: it is a Mac-specific behavior.

> LayoutTests/editing/selection/context-menu-text-selection.html:34
> +    var onWinPlatform = navigator.userAgent.search(/\bWindows\b/) != -1;
> +    if (onWinPlatform) {
> +	   if (window.getSelection().type != "None")

This is not the right way to test this. See
LayoutTestController::setEditingBehavior. grep for it. It basically makes it
possible to test all editing behavior and having test expectations shared cross
all platforms..