[webkit-reviews] review granted: [Bug 49350] bufferData/bufferSubData should not crash with null data input : [Attachment 73673] revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 11 15:50:05 PST 2010


Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 49350: bufferData/bufferSubData should not crash with null data input
https://bugs.webkit.org/show_bug.cgi?id=49350

Attachment 73673: revised patch
https://bugs.webkit.org/attachment.cgi?id=73673&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73673&action=review

Looks fine; could you please add one comment to the test while landing?

> LayoutTests/fast/canvas/webgl/buffer-data-array-buffer.html:32
> +gl.bufferData(gl.ARRAY_BUFFER, null, gl.STATIC_DRAW);
> +gl.getError();

Could you add a comment like "this should not crash, but the selection of the
overload is ambiguous per Web IDL"?


More information about the webkit-reviews mailing list