[webkit-reviews] review denied: [Bug 49119] Add AudioNode custom bindings : [Attachment 73152] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 49119: Add AudioNode custom bindings
https://bugs.webkit.org/show_bug.cgi?id=49119

Attachment 73152: Patch
https://bugs.webkit.org/attachment.cgi?id=73152&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73152&action=review

Basically looks fine; r- for unnecessary checks.

> WebCore/bindings/js/JSAudioNodeCustom.cpp:42
> +    if (exec->argumentCount() > 3)
> +	   return throwError(exec, createSyntaxError(exec, "Too many
arguments"));

It isn't an error to pass too many arguments to a JavaScript function.

> WebCore/bindings/js/JSAudioNodeCustom.cpp:68
> +    if (exec->argumentCount() > 1)
> +	   return throwError(exec, createSyntaxError(exec, "Too many
arguments"));

Unnecessary check per above.

> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:45
> +    if (args.Length() > 3)
> +	   return throwError("Too many arguments", V8Proxy::SyntaxError);

Unnecessary check per above.

> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:77
> +    if (args.Length() > 1)
> +	   return throwError("Too many arguments", V8Proxy::SyntaxError);

Unnecessary check per above.