[webkit-reviews] review denied: [Bug 49357] Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent : [Attachment 73565] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 49357: Add Event and EventListener hooks for JavaScriptAudioNode and
AudioProcessingEvent
https://bugs.webkit.org/show_bug.cgi?id=49357

Attachment 73565: Patch
https://bugs.webkit.org/attachment.cgi?id=73565&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73565&action=review

This looks good overall. r- for the unrelated header reorderings. If
check-webkit-style is complaining then try webkit-patch upload to upload your
next patch, which I believe will only run the style checker against the changed
portions of your diff.

> WebCore/bindings/js/JSEventTarget.cpp:66
> -#include "SVGElementInstance.h"
>  #include "JSSVGElementInstance.h"
> +#include "SVGElementInstance.h"

This looks like an unrelated change that should go in a separate patch.

> WebCore/bindings/js/JSEventTarget.cpp:98
> -#include "JSFileReader.h"
>  #include "FileReader.h"
> +#include "JSFileReader.h"

This looks like an unrelated change that should go in a separate patch.