[webkit-reviews] review granted: [Bug 49360] new-run-webkit-tests: respect set-webkit-configuration again : [Attachment 73665] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 11 14:38:13 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 49360: new-run-webkit-tests: respect set-webkit-configuration again
https://bugs.webkit.org/show_bug.cgi?id=49360

Attachment 73665: Patch
https://bugs.webkit.org/attachment.cgi?id=73665&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73665&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/port/config_standalone.py:56
> +    else:
> +	   e = executive.Executive()
> +	   fs = filesystem.FileSystem()

Is this really needed? It's never used.


More information about the webkit-reviews mailing list