[webkit-reviews] review requested: [Bug 49351] More ResourceLoadScheduler cleanup : [Attachment 73629] Make ResourceLoader::start() protect and friend ResourceLoadScheduler
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 11 11:24:20 PST 2010
Nate Chapin <japhet at chromium.org> has asked for review:
Bug 49351: More ResourceLoadScheduler cleanup
https://bugs.webkit.org/show_bug.cgi?id=49351
Attachment 73629: Make ResourceLoader::start() protect and friend
ResourceLoadScheduler
https://bugs.webkit.org/attachment.cgi?id=73629&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
Just saw your post. I was about to post this patch, so I figured I'd go ahead
and get your opinion as to whether this is better or worse than leaving sending
deferred loads back through ResourceLoadScheduler.
We had talked in #webkit on Monday about making ResourceLoadScheduler a friend
of ResourceLoader, so that start() no longer needed to be public. I believe
that, if this is the case, it may remove one of the main needs for
assertLoaderBeingCounted() (that the load might have been started without going
through ResourceLoadScheduler).
I don't have strong feelings on which technique we go with, but I figured I
should post this one since the work was already done :)
More information about the webkit-reviews
mailing list