[webkit-reviews] review denied: [Bug 48625] [GTK] Optimize foldCase, toLower and toUpper methods in glib unicode backend : [Attachment 72319] Fixed minor coding style issue in previous patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 48625: [GTK] Optimize foldCase, toLower and toUpper methods in glib unicode
backend
https://bugs.webkit.org/show_bug.cgi?id=48625

Attachment 72319: Fixed minor coding style issue in previous patch
https://bugs.webkit.org/attachment.cgi?id=72319&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72319&action=review

Looks good. It just needs a couple small cleanups.

> JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp:58
> +	   utf16Length += (character >= 0x10000) ? 2 : 1;

There's a macro in TextBreakIterator.h for this.

> JavaScriptCore/wtf/unicode/glib/UnicodeGLib.cpp:83
> +    GOwnPtr<char> utf8Result;
> +    utf8Result.set(caseFunction(buffer.data(), buffer.size()));

I think it makes more sense for this to be:

GOwnPtr<char> utf8Result(caseFunction(buffer.data(), buffer.size());