[webkit-reviews] review granted: [Bug 49284] SVGAnimation calcMode="spline" should use 'to' 'by' animation if no values were specified : [Attachment 73607] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 49284: SVGAnimation calcMode="spline" should use 'to' 'by' animation if no
values were specified
https://bugs.webkit.org/show_bug.cgi?id=49284

Attachment 73607: Patch
https://bugs.webkit.org/attachment.cgi?id=73607&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73607&action=review

Tests look great, please change bug title and clarify changelog, r=me.

> WebCore/ChangeLog:5
> +	   SVGAnimation calcMode="spline" should use 'to' 'by' animation if no
values were specified

The bug title is unclear, wheter you mean 'to-by' animation or 'to or by
animation'.

> WebCore/ChangeLog:8
> +	   Add support for from-to-by animations in combination with calcMode
'spline' for SVGAnimations.

from-to-by?
you mean from-to / from-by ?

> WebCore/svg/SVGAnimationElement.cpp:515
>	   unsigned num = m_keySplines.size() + 1;

s/num/splinesCount/  ?