[webkit-reviews] review granted: [Bug 49056] [GTK] Spatial Navigation: snav-input.html and snav-textarea.html fail : [Attachment 73603] fix patch 2

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 49056: [GTK] Spatial Navigation: snav-input.html and snav-textarea.html
fail
https://bugs.webkit.org/show_bug.cgi?id=49056

Attachment 73603: fix patch 2
https://bugs.webkit.org/attachment.cgi?id=73603&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73603&action=review

Looks nice! Lets just fix the style issues before landing.

> WebKit/gtk/ChangeLog:6
> +	   [GTK] Replace "MoveForward"/"MoveBackward" with
"MoveRight"/"MoveLeft"
> +	   to make spatial navigation work on input/textarea.

You need the bug title here. Implementation details goes right below that.

> WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:220
> +	   if (direction == 1)
> +	       rawCommand = "MoveRight";
> +	   else if (!direction)
> +	       rawCommand = "MoveLeft";

rawCommand = direction ? "MoveRight" ? "MoveLeft";

> LayoutTests/ChangeLog:5
> +	   [GTK] Unskip tests that are passing now.

same here: first bug title , bugzilla entry url, then the description.