[webkit-reviews] review denied: [Bug 49351] More ResourceLoadScheduler cleanup : [Attachment 73578] Patch for landing

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 49351: More ResourceLoadScheduler cleanup
https://bugs.webkit.org/show_bug.cgi?id=49351

Attachment 73578: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=73578&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Seems I was hasty with r+. Browsing around on mac with this patch asserts very
quickly. I think calling CachedResource::setDefersLoading(false) should call to
ResourceLoadScheduler to schedule the load, instead of calling start()
directly.

I would be good if you could do some basic browsing using Mac debug build with
this type of patches as that catches many issues not covered by the tests.

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   com.apple.WebCore			0x00000001021badca
WebCore::ResourceLoadScheduler::HostInformation::assertLoaderBeingCounted(WebCo
re::ResourceLoader*) + 218 (ResourceLoadScheduler.cpp:248)
1   com.apple.WebCore			0x00000001021bbc17
WebCore::ResourceLoadScheduler::assertLoaderBeingCounted(WebCore::ResourceLoade
r*) + 115 (ResourceLoadScheduler.cpp:235)
2   com.apple.WebCore			0x0000000101f85dd2
WebCore::ResourceLoader::start() + 280 (ResourceLoader.cpp:144)
3   com.apple.WebCore			0x0000000101f8616c
WebCore::ResourceLoader::setDefersLoading(bool) + 290 (ResourceLoader.cpp:177)
4   com.apple.WebCore			0x000000010170aa0b
WebCore::setAllDefersLoading(WTF::HashSet<WTF::RefPtr<WebCore::ResourceLoader>,
WTF::PtrHash<WTF::RefPtr<WebCore::ResourceLoader> >,
WTF::HashTraits<WTF::RefPtr<WebCore::ResourceLoader> > > const&, bool) + 135
(DocumentLoader.cpp:70)
5   com.apple.WebCore			0x000000010170ab8d
WebCore::DocumentLoader::setDefersLoading(bool) + 91 (DocumentLoader.cpp:694)
6   com.apple.WebCore			0x00000001018711bc
WebCore::FrameLoader::setDefersLoading(bool) + 74 (FrameLoader.cpp:251)
7   com.apple.WebCore			0x0000000101ddfb55
WebCore::Page::setDefersLoading(bool) + 113 (Page.cpp:579)
8   com.apple.WebKit			0x0000000100fefc9d
-[WebView(WebPrivate) setDefersCallbacks:] + 115 (WebView.mm:2218)
9   com.apple.Safari			0x000000010008cee6 0x100000000 + 577254

10  com.apple.JavaScriptCore		0x000000010088f137
WTF::dispatchFunctionsFromMainThread() + 242 (MainThread.cpp:156)
11  com.apple.JavaScriptCore		0x0000000100890ad4
-[WTFMainThreadCaller call] + 21 (MainThreadMac.mm:48)