[webkit-reviews] review granted: [Bug 49311] Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept : [Attachment 73522] Patch v2

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 49311: Convert SVGMatrix/SVGTransform/SVGTransformList to the new
SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49311

Attachment 73522: Patch v2
https://bugs.webkit.org/attachment.cgi?id=73522&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73522&action=review

We already talked about some issues on IRC, just add some notes to bugzilla
review as well. I may forgot to note some change wishes here :-) Niko already
fixed Mac.

Great Patch Niko! Looking forward to see the same work on SVGPathSegList :-D

r=me

> WebCore/svg/SVGTransformList.cpp:66
> +    return String::format("matrix(%f %f %f %f %f %f)", matrix.a(),
matrix.b(), matrix.c(), matrix.d(), matrix.e(), matrix.f());

Don't use String::format here ;-) We talked about this on IRC right now.

> WebCore/svg/SVGTransformable.cpp:192
> +	   list.append(t);

Can you rename t to transform please? And please fix the indentation as well on
switch .. case later in the code.