[webkit-reviews] review denied: [Bug 49240] Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags : [Attachment 73591] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 11 02:21:44 PST 2010
Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 49240: Implement formaction, formenctype, formmethod and formtarget
attributes for input and button tags
https://bugs.webkit.org/show_bug.cgi?id=49240
Attachment 73591: Patch
https://bugs.webkit.org/attachment.cgi?id=73591&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73591&action=review
> WebCore/html/HTMLInputElement.idl:31
> + attribute [Reflect, URL] DOMString formAction;
> + attribute [ConvertNullToNullString] DOMString formEnctype;
> + attribute [Reflect] DOMString formMethod;
> attribute [Reflect] boolean formNoValidate;
> + attribute [Reflect] DOMString formTarget;
We need a similar change for HTMLButtonElement.idl.
Also, we need tests for accessing them by JavaScript properties. e.g.
input.formAction reflects formaction= HTML attribute correctly?
More information about the webkit-reviews
mailing list