[webkit-reviews] review granted: [Bug 49353] ComplexTextController not prepared to handle multiple runs : [Attachment 73576] Changes per review.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 10 21:17:40 PST 2010
mitz at webkit.org has granted nholbrook at apple.com's request for review:
Bug 49353: ComplexTextController not prepared to handle multiple runs
https://bugs.webkit.org/show_bug.cgi?id=49353
Attachment 73576: Changes per review.
https://bugs.webkit.org/attachment.cgi?id=73576&action=review
------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=73576&action=review
> WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp:59
> + if (runRange.location)
> + for (unsigned i = 0; i < m_glyphCount; ++i)
> + m_coreTextIndicesVector[i] -= runRange.location;
The WebKit style guidelines say that a multi-line block needs to be in braces.
I’ll fix this when I land the patch.
More information about the webkit-reviews
mailing list