[webkit-reviews] review granted: [Bug 49296] FileSystem: Fix a link error for non-chromium WebKit build : [Attachment 73506] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 10 20:07:34 PST 2010


Jian Li <jianli at chromium.org> has granted Kavita Kanetkar
<kkanetkar at chromium.org>'s request for review:
Bug 49296: FileSystem: Fix a link error for non-chromium WebKit build
https://bugs.webkit.org/show_bug.cgi?id=49296

Attachment 73506: patch
https://bugs.webkit.org/attachment.cgi?id=73506&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73506&action=review

Looks good except the minor issue. Please fix it before you land the patch.

> WebCore/inspector/InspectorFileSystemAgent.cpp:127
> +void InspectorFileSystemAgent::revealFolderInOS(const String&) { }

Please add "notImplemented();".


More information about the webkit-reviews mailing list