[webkit-reviews] review denied: [Bug 49329] Do not allow access to session and local storage when in private browsing mode : [Attachment 73561] [PATCH] Do not allow access to session and local storage when in private browsing mode (with ChangeLog)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Anton D'Auria <adauria at apple.com>'s
request for review:
Bug 49329: Do not allow access to session and local storage when in private
browsing mode
https://bugs.webkit.org/show_bug.cgi?id=49329

Attachment 73561: [PATCH] Do not allow access to session and local storage when
in private browsing mode (with ChangeLog)
https://bugs.webkit.org/attachment.cgi?id=73561&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73561&action=review

> WebCore/storage/Storage.cpp:59
> -    if (!m_frame)
> +    if (!m_frame || m_frame->page()->settings()->privateBrowsingEnabled())

We need to null-check page too. It’s possible for a frame to outlive its page
and thus have 0 for a page. But settings is guaranteed to be non-zero for any
page.

Sorry, I missed that earlier.