[webkit-reviews] review granted: [Bug 32412] css2:order of counters in out-of flow content : [Attachment 73530] Proposed Patch addressed concerns about misleading ChangeLog entry.

Wed Nov 10 17:31:49 PST 2010

Kent Tamura <tkent at chromium.org> has granted Carol Szabo
<carol.szabo at nokia.com>'s request for review:
Bug 32412: css2:order of counters in out-of flow content
https://bugs.webkit.org/show_bug.cgi?id=32412

Attachment 73530: Proposed Patch addressed concerns about misleading ChangeLog
entry.
https://bugs.webkit.org/attachment.cgi?id=73530&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73530&action=review

Looks almost ok.

> LayoutTests/fast/css/content/content-none.html:16
> +	       function run() {
> +		testWidth =
window.getComputedStyle(document.getElementById("testContainer"),
null).getPropertyValue("width");
> +		  
referenceWidth=window.getComputedStyle(document.getElementById("reference"),
null).getPropertyValue("width");

Indentation error

> LayoutTests/fast/css/content/content-none.html:27
> +    <body onload="setTimeout('run()', 0);">

Is setTimeout() necessary?

> LayoutTests/fast/css/content/content-normal.html:16
> +	       function run() {
> +		testWidth =
window.getComputedStyle(document.getElementById("testContainer"),
null).getPropertyValue("width");
> +		  
referenceWidth=window.getComputedStyle(document.getElementById("reference"),
null).getPropertyValue("width");

Indentation error

> LayoutTests/fast/css/content/content-normal.html:27
> +    <body onload="setTimeout('run()', 0);">

Is setTimeout() necessary?