[webkit-reviews] review requested: [Bug 49333] simplify png decoding loop : [Attachment 73548] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 10 15:13:13 PST 2010
Pascal Massimino <pascal.massimino at gmail.com> has asked for review:
Bug 49333: simplify png decoding loop
https://bugs.webkit.org/show_bug.cgi?id=49333
Attachment 73548: updated patch
https://bugs.webkit.org/attachment.cgi?id=73548&action=review
------- Additional Comments from Pascal Massimino <pascal.massimino at gmail.com>
updated patch, with smaller PNG test image and fixed ChangeLog.
This test-PNG has an alpha-less first and last row, whereas the center
rows do have alpha. So whether setHasAlpha() occurs first or last, it
would be forcing a no-alpha bad image.
That being said, i see no effect of setHasAlpha() on linux. The renderer
seems to ignore this global flag and use whatever alpha value is associated
with each pixels.
More information about the webkit-reviews
mailing list