[webkit-reviews] review granted: [Bug 49347] Push m_viewSize down to DrawingAreaProxy base class : [Attachment 73544] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 10 14:55:23 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 49347: Push m_viewSize down to DrawingAreaProxy base class
https://bugs.webkit.org/show_bug.cgi?id=49347

Attachment 73544: Patch
https://bugs.webkit.org/attachment.cgi?id=73544&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73544&action=review

> WebKit2/UIProcess/DrawingAreaProxy.h:57
> +    WebCore::IntSize size() const { return m_size; }

This can return a reference to const.

> WebKit2/UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:50
> +    IntSize viewSize = size();

This can be a reference to const.


More information about the webkit-reviews mailing list