[webkit-reviews] review granted: [Bug 49330] [chromium] Canvas getImageData/putImageData cycle should not change values for valid premultiplied colours. : [Attachment 73516] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 49330: [chromium] Canvas getImageData/putImageData cycle should not change
values for valid premultiplied colours.
https://bugs.webkit.org/show_bug.cgi?id=49330

Attachment 73516: Patch
https://bugs.webkit.org/attachment.cgi?id=73516&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73516&action=review

R=me, please consider comment.

> WebCore/platform/graphics/skia/ImageBufferSkia.cpp:241
> +// This function does the equivalent of (a * b + 254) / 255, without an
integer divide.

Is there any reason to avoid an integer divide?  I think it'd be a lot easier
to read that way and the compiler can figure out the best code to generate for
a given platform.