[webkit-reviews] review denied: [Bug 49306] Fix autofill popup height computation : [Attachment 73467] Patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has denied  review:
Bug 49306: Fix autofill popup height computation
https://bugs.webkit.org/show_bug.cgi?id=49306

Attachment 73467: Patch
https://bugs.webkit.org/attachment.cgi?id=73467&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73467&action=review

It's nice if we can add a test (maybe manual test, unfortunately) for this
change.

> WebCore/platform/chromium/PopupMenuChromium.cpp:1301
> +    int y = 0;

I think we can just reuse windowHeight and we don't need this variable?

> WebCore/platform/chromium/PopupMenuChromium.cpp:1307
> +	   y += rowHeight;

Could you check if this test
http://trac.webkit.org/browser/trunk/WebCore/manual-tests/display-none-option.h
tml?rev=71727 still works? I guess we need

if (!m_popupClient->itemStyle(i).isDisplayNone())

here.