[webkit-reviews] review granted: [Bug 49302] Add a test for form submission by <input type=image> : [Attachment 73461] Patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 49302: Add a test for form submission by <input type=image>
https://bugs.webkit.org/show_bug.cgi?id=49302

Attachment 73461: Patch
https://bugs.webkit.org/attachment.cgi?id=73461&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73461&action=review

Adding more tests is nice :) I've put two minor comments, please apply them if
you like.

> LayoutTests/fast/forms/input-image-submit.html:37
> +	   gc();

I think the reason why we need to run gc here isn't so clear. Could you write a
few comments?

> LayoutTests/fast/forms/input-image-submit.html:72
> +	       testFailed('Normal submission failed: ' + query);

I'd add a function which calls both testFailed and notifyDone.