[webkit-reviews] review denied: [Bug 48812] FrameLoader::checkLoadCompleteForThisFrame uses wrong history item : [Attachment 73449] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Charles Reis
<creis at chromium.org>'s request for review:
Bug 48812: FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Attachment 73449: Patch
https://bugs.webkit.org/attachment.cgi?id=73449&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
A general note: any design that involves both HistoryItem and ResourceRequest
seems suspicious. These are pretty distant layers to talk to each other.

Requests already have identifiers, see e.g.
FrameLoaderClient::assignIdentifierToInitialRequest(). Adding another "ID"
would be terribly confusing.

And of course m_id won't persist a Mac Objective-C API delegate call. See
<http://trac.webkit.org/browser/trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderC
lient.mm#L387> - the request is re-created from scratch after a client has a
chance to modify it.