[webkit-reviews] review denied: [Bug 47813] [HTML5] "form" attribute support for form control elements : [Attachment 73367] Patch V2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 47813: [HTML5] "form" attribute support for form control elements
https://bugs.webkit.org/show_bug.cgi?id=47813

Attachment 73367: Patch V2
https://bugs.webkit.org/attachment.cgi?id=73367&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73367&action=review

> LayoutTests/fast/forms/script-tests/form-attribute-elements-order.js:5
> +container.innerHTML = '<input name="victim" id="before1" form="owner" />' +

nit: You don't need double-quotes surrounding attribute values in many cases.

> LayoutTests/fast/forms/script-tests/form-attribute.js:34
> +debug('- Ensures that the form attribute points the form owner even if the
element is within another form element.');
> +container.innerHTML = '<form id="owner"></form>' +
> +    '<form id="shouldNotBeOwner">' +
> +    '    <input id="inputElement" name="victim" form="owner" />' +
> +    '</form>';

How about the following similar case?

<form id=owner>
 <form id=shouldNotBeOwner>
  <input id=inputElement name=victime form=owner>
 </form>
</form>

> WebCore/html/HTMLFormElement.cpp:406
> +unsigned
HTMLFormElement::formElementIndexWithFormAttribute(HTMLFormControlElement*
element)

Does this work if the element is inside of the form?

<form id=owner>
  <input>
  <input form=owner>
  <input>
</form>

or


<form id=owner>
  <form>
   <input>
   <input form=owner>
   <input>
  </form>
</form>