[webkit-reviews] review granted: [Bug 48282] WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0 implementations : [Attachment 73446] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 9 17:47:49 PST 2010


James Robinson <jamesr at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 48282: WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0
implementations
https://bugs.webkit.org/show_bug.cgi?id=48282

Attachment 73446: Patch
https://bugs.webkit.org/attachment.cgi?id=73446&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
R=me

one suggestion: consider making the isGLES2 flag a member and check that
instead of having checks for gfx::GetGLImplementation() everywhere.


More information about the webkit-reviews mailing list