[webkit-reviews] review requested: [Bug 23432] window.open scripts do not trigger newWindowDelegate callback. : [Attachment 73416] [PATCH 2/4] Show window only after initial location request

[bugzilla-daemon at webkit.org]

Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> has asked  for review:
Bug 23432: window.open scripts do not trigger newWindowDelegate callback.
https://bugs.webkit.org/show_bug.cgi?id=23432

Attachment 73416: [PATCH 2/4] Show window only after initial location request
https://bugs.webkit.org/attachment.cgi?id=73416&action=review

------- Additional Comments from Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>
To fix this bug we enabled creating hidden windows. This patch takes
benifit of this new feature and queue location change before calling
Page::chrome()->show(). This mean URI can be considered sooner by
non-destructive popup blocker like the one in Chrome.