[webkit-reviews] review requested: [Bug 49018] [GTK] response.isNull() assert when using directory file URI : [Attachment 73407] Fix assert using directory file URI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 9 13:36:46 PST 2010


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> has asked  for review:
Bug 49018: [GTK] response.isNull() assert when using directory file URI
https://bugs.webkit.org/show_bug.cgi?id=49018

Attachment 73407: Fix assert using directory file URI
https://bugs.webkit.org/attachment.cgi?id=73407&action=review

------- Additional Comments from Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>
As requested I've reused the check that decided if GIO should be used and send
a response in this case in sendRequestCallback(), also added assert to check we
don't send twice and that we have sent a response.

At first I though that we could simply check for m_response.isNull() in
sendRequestCallback(), but found out that contentSniffedCallback() may be
called after with HTTP streams, which leads to sending two responses.


More information about the webkit-reviews mailing list