[webkit-reviews] review granted: [Bug 49187] [NRWT] Make http locking similar to perl implementation : [Attachment 73402] proposed_patch_02

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 49187: [NRWT] Make http locking similar to perl implementation
https://bugs.webkit.org/show_bug.cgi?id=49187

Attachment 73402: proposed_patch_02
https://bugs.webkit.org/attachment.cgi?id=73402&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73402&action=review

> WebKitTools/Scripts/webkitpy/common/system/file_lock_unittest.py:58
> +	   open(self._lock_path, 'w')

Nit: There should be a .close() here to explicitly release the file handle.

To answer Eric's question: This is testing a stale lock file (that no one has a
flock on) and the call to open is just to create the file (i.e., unix touch).