[webkit-reviews] review denied: [Bug 49018] [GTK] response.isNull() assert when using directory file URI : [Attachment 73316] Fix assert using directory file URI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 9 09:54:33 PST 2010


Gustavo Noronha (kov) <gns at gnome.org> has denied Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>'s request for review:
Bug 49018: [GTK] response.isNull() assert when using directory file URI
https://bugs.webkit.org/show_bug.cgi?id=49018

Attachment 73316: Fix assert using directory file URI
https://bugs.webkit.org/attachment.cgi?id=73316&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
As discussed on IRC, given the API is not set in stone, and the conceptually
more correct fix for the current situation is to make the check on
sendRequestCallback less strict, we'll go with that and rely on ASSERT to make
sure we don't forget to dispatch a response where needed.


More information about the webkit-reviews mailing list