[webkit-reviews] review requested: [Bug 48150] [Mac] LayoutTests/fast/events/spatial-navigation/snav-single-select.html hangs : [Attachment 73381] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 9 08:38:23 PST 2010


Chang Shu <Chang.Shu at nokia.com> has asked  for review:
Bug 48150: [Mac]
LayoutTests/fast/events/spatial-navigation/snav-single-select.html hangs
https://bugs.webkit.org/show_bug.cgi?id=48150

Attachment 73381: fix patch
https://bugs.webkit.org/attachment.cgi?id=73381&action=review

------- Additional Comments from Chang Shu <Chang.Shu at nokia.com>
Here is basically what I did in this patch:
When ARROW_KEYS_POP_MENU is defined, which is the case on Mac, do up/down key
pop menu only when spatial navigation is not enabled. And when spatial
navigation is enabled, do the work flow as if ARROW_KEYS_POP_MENU is not
defined so that selecting items is allowed.


More information about the webkit-reviews mailing list